cyb70289 commented on code in PR #37785:
URL: https://github.com/apache/arrow/pull/37785#discussion_r1333980467
##########
go/parquet/internal/bmi/bitmap_neon_arm64.s:
##########
@@ -27,8 +27,8 @@ LBB0_2:
MOVD R0, res+16(FP)
RET
LBB0_4:
- WORD $0xaa1f03e0 // mov x0, xzr
WORD $0xa8c17bfd // ldp x29, x30, [sp], #16
+ MOVD ZR, res+16(FP)
Review Comment:
Wrote a
[benchmark](https://github.com/cyb70289/mytests/blob/master/go/bmi/bmi_test.go),
the golang version is indeed faster than assembly. Tested on Neoverse-N1.
```
$ go test -bench=.
goos: linux
goarch: arm64
pkg: bmi
BenchmarkGo-80 663 1759920 ns/op
BenchmarkAsm-80 435 2720235 ns/op
PASS
ok bmi 2.838s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
