seddonm1 commented on a change in pull request #9038: URL: https://github.com/apache/arrow/pull/9038#discussion_r552947771
########## File path: rust/datafusion/src/optimizer/utils.rs ########## @@ -416,6 +424,7 @@ pub fn rewrite_expression(expr: &Expr, expressions: &Vec<Expr>) -> Result<Expr> Ok(expr) } } + Expr::InList { .. } => Ok(expr.clone()), Review comment: Here this is just cloning the while `InList` expression (not the `expr` in `InList`) as the optimiser is not doing anything for this Expression yet. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org