seddonm1 commented on pull request #9038: URL: https://github.com/apache/arrow/pull/9038#issuecomment-755664456
@alamb thanks for taking the time to review this as I know it ended up as quite a large PR 👍 . I have updated based on your comment. @yordan-pavlov yes this is basically as naive implementation as possible and could be heavily optimised. I think we should merge this PR to unblock TPC-H Query 12: `l_shipmode in ('MAIL', 'SHIP')` then look at optimisation. The test cases should help with any future optimisation work anyway. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org