abandy commented on code in PR #37764:
URL: https://github.com/apache/arrow/pull/37764#discussion_r1332355177
##########
swift/Arrow/Sources/Arrow/ArrowWriter.swift:
##########
@@ -38,7 +38,7 @@ public class ArrowWriter {
self.data.append(data)
}
}
-
+
Review Comment:
I wasn't too concerned with these style changes as I was going to follow up
with a swiftlint PR. Since we are planning on running swiftlint on the code as
a prior PR to this one, then these will be resolved (should be) when swiftlint
is run against the files.
##########
swift/Arrow/Sources/Arrow/ArrowReader.swift:
##########
@@ -200,4 +201,41 @@ public class ArrowReader {
return .failure(.unknownError("Error loading file: \(error)"))
}
}
+
+ static public func MakeArrowReaderResult() -> ArrowReaderResult{
Review Comment:
Will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
