abandy commented on PR #37764: URL: https://github.com/apache/arrow/pull/37764#issuecomment-1728653507
> How about using the following steps instead of "merging this PR without SwiftLint and applying SwiftLint with a separated PR"? > > 1. PR1: Add a lint CI job > > * We can do it in https://github.com/apache/arrow/blob/main/ci/scripts/swift_test.sh > * We can apply SwiftLint in PR1 to fix CI failure > * We don't change any behavior in PR1 (Auto-generated changed by SwiftLint are only included in PR1) > 2. PR2: Rebase this PR on main after PR1 is merged > > * Formatted changes are easier to review > 3. PR3: Add Swift to our integration test targets: > > * Add `tester_swift.py` to https://github.com/apache/arrow/tree/main/dev/archery/archery/integration > * Enable the tester in https://github.com/apache/arrow/blob/main/dev/archery/archery/integration/runner.py#L534 > * Setup Swift in https://github.com/apache/arrow/blob/main/ci/docker/conda-integration.dockerfile > > BTW, could you add a list of changed behavior in the description of this PR? It seems that no response cases are changed. Sounds good, I will give this a go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
