bkietz commented on code in PR #37792:
URL: https://github.com/apache/arrow/pull/37792#discussion_r1334432857
##########
cpp/src/arrow/array/validate.cc:
##########
@@ -74,10 +76,7 @@ struct BoundsChecker {
int64_t min_value;
int64_t max_value;
- Status Visit(const DataType&) {
- // Default, should be unreachable
- return Status::NotImplemented("");
- }
+ Status Visit(const DataType&) { Unreachable("bounds checking of non integer
type"); }
Review Comment:
This is currently used exclusively for bounds checking dictionary indices,
which are always integers. Perhaps this class should be renamed or inlined into
`ValidateArrayImpl::Visit(const arrow::DictionaryType& type)`. This change was
made in passing and doesn't directly relate to string view so I'll just remove
it for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
