bkietz commented on code in PR #37792:
URL: https://github.com/apache/arrow/pull/37792#discussion_r1334434815
##########
cpp/src/arrow/array/builder_binary.cc:
##########
@@ -40,6 +40,72 @@ namespace arrow {
using internal::checked_cast;
+// ----------------------------------------------------------------------
+// Binary/StringView
+BinaryViewBuilder::BinaryViewBuilder(const std::shared_ptr<DataType>& type,
+ MemoryPool* pool)
+ : BinaryViewBuilder(pool) {
+ ARROW_CHECK(!checked_cast<const BinaryViewType&>(*type).has_raw_pointers());
Review Comment:
It certainly could (and does in a previous version of this PR) but I'm
trying to keep this patch as small as possible. I can add that feature in a
follow up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
