Ted-Jiang commented on code in PR #7620:
URL: https://github.com/apache/arrow-datafusion/pull/7620#discussion_r1335130387
##########
datafusion/core/src/execution/context.rs:
##########
@@ -1405,6 +1405,15 @@ pub fn default_session_builder(config: SessionConfig) ->
SessionState {
SessionState::with_config_rt(config, Arc::new(RuntimeEnv::default()))
}
+impl Default for SessionState {
Review Comment:
Yes, it there are many options to set in `SessionState `, i just want to
write less code when construct SessionState see there are already default in
`SessionConfig` and `RuntimeEnv` 😂 ， it make sense let user point what conf
they want.
##########
datafusion/core/src/execution/context.rs:
##########
@@ -1405,6 +1405,15 @@ pub fn default_session_builder(config: SessionConfig) ->
SessionState {
SessionState::with_config_rt(config, Arc::new(RuntimeEnv::default()))
}
+impl Default for SessionState {
Review Comment:
Yes, it there are many options to set in `SessionState `, i just want to
write less code when construct SessionState see there are already default in
`SessionConfig` and `RuntimeEnv` 😂 ， it make sense let user point what conf
they want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
