alamb commented on code in PR #7620:
URL: https://github.com/apache/arrow-datafusion/pull/7620#discussion_r1336280585
##########
datafusion/core/src/execution/context.rs:
##########
@@ -1405,6 +1405,15 @@ pub fn default_session_builder(config: SessionConfig) ->
SessionState {
SessionState::with_config_rt(config, Arc::new(RuntimeEnv::default()))
}
+impl Default for SessionState {
Review Comment:
I think we should remove the `Default` impl and instead have a function for
tests (`test_session_state()` or similar) to avoid misuse of this API.
Here is a PR to add some comments about the rationale for not having a
`Default` impl: https://github.com/apache/arrow-datafusion/pull/7654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
