bkietz commented on code in PR #37792:
URL: https://github.com/apache/arrow/pull/37792#discussion_r1337430852
##########
cpp/src/arrow/json/converter.cc:
##########
@@ -304,6 +304,8 @@ Status MakeConverter(const std::shared_ptr<DataType>&
out_type, MemoryPool* pool
CONVERTER_CASE(Type::STRING, BinaryConverter<StringType>);
CONVERTER_CASE(Type::LARGE_BINARY, BinaryConverter<LargeBinaryType>);
CONVERTER_CASE(Type::LARGE_STRING, BinaryConverter<LargeStringType>);
+ CONVERTER_CASE(Type::BINARY_VIEW, BinaryConverter<BinaryViewType>);
+ CONVERTER_CASE(Type::STRING_VIEW, BinaryConverter<StringViewType>);
Review Comment:
I thought it was. I've added an explicit case for conversion to string view
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
