bkietz commented on code in PR #37792:
URL: https://github.com/apache/arrow/pull/37792#discussion_r1337448461
##########
cpp/src/arrow/array/builder_dict.h:
##########
@@ -115,6 +121,10 @@ class ARROW_EXPORT DictionaryMemoTable {
Status GetOrInsert(const BinaryType*, std::string_view value, int32_t* out);
Status GetOrInsert(const LargeBinaryType*, std::string_view value, int32_t*
out);
+ // TODO: Consider working BinaryViewType::c_type throughout the hashing
machinery to
+ // benefit from faster comparisons, reduced need to allocate memory
Review Comment:
Well not just the prefix, but similar to equality and ordered comparison
there *is* a fast path available for hashing of string views (though not in
this PR). I'll remove the TODO and add a follow up issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
