paleolimbot commented on code in PR #37828:
URL: https://github.com/apache/arrow/pull/37828#discussion_r1338756187
##########
r/tests/testthat/test-dataset-csv.R:
##########
@@ -561,6 +561,18 @@ test_that("open_delim_dataset params passed through to
open_dataset", {
expect_named(ds, c("int", "dbl", "lgl", "chr", "fct", "ts"))
+ # quoted_na
+ dst_dir <- make_temp_dir()
+ dst_file <- file.path(dst_dir, "data.csv")
+ df <- data.frame(text = c("one", "two", "", "four"), num = 1:4)
+ write.csv(df, dst_file, row.names = FALSE, quote = FALSE)
Review Comment:
Is this the same as `write("one\ntwo\nthree\n\nfour")` (It might be a tiny
bit clearer what's actually getting tested to just write the contents of the
file or put it in a comment...I forget what all the arguments of `write.csv()`
actually do!)
##########
r/tests/testthat/test-dataset-csv.R:
##########
@@ -253,7 +253,7 @@ test_that("readr parse options", {
tsv_dir,
partitioning = "part",
format = "text",
- quo = "\"",
+ del = ","
Review Comment:
Is this change intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
