thisisnic commented on code in PR #37828:
URL: https://github.com/apache/arrow/pull/37828#discussion_r1340661250
##########
r/tests/testthat/test-dataset-csv.R:
##########
@@ -253,7 +253,7 @@ test_that("readr parse options", {
tsv_dir,
partitioning = "part",
format = "text",
- quo = "\"",
+ del = ","
Review Comment:
Yep - because passing in a parameter as `quo` (not a valid parameter name)
no longer constitutes a unique partial match to either the readr or arrow
options, it is caught earlier on in input validation and so raises an
"Unrecognized option" error instead of an "Ambiguous option" error. This input
validation is something it would be nice to refactor in another PR, but I
figured here we just want to replace `quo` with something else that takes us
down the "Ambiguous option" path to stick with the spirit of the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
