CurtHagenlocher commented on code in PR #37904:
URL: https://github.com/apache/arrow/pull/37904#discussion_r1338846999
##########
csharp/src/Apache.Arrow/C/CArrowArrayExporter.cs:
##########
@@ -190,26 +191,43 @@ private unsafe static void
ConvertRecordBatch(ExportedAllocationOwner sharedOwne
#endif
private unsafe static void ReleaseArray(CArrowArray* cArray)
{
- Dispose(&cArray->private_data);
+ for (long i = 0; i < cArray->n_children; i++)
+ {
+ CArrowArray.CallReleaseFunc(cArray->children[i]);
+ }
+ if (cArray->dictionary != null) {
Review Comment:
While I have a personal preference for 1TBS, the rest of the code (and the
default in VS) uses Allman-style braces and it would be nice to match. (Applies
to a few other locations.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
