pitrou commented on code in PR #37904:
URL: https://github.com/apache/arrow/pull/37904#discussion_r1338851521
##########
csharp/src/Apache.Arrow/C/CArrowArrayExporter.cs:
##########
@@ -190,26 +191,43 @@ private unsafe static void
ConvertRecordBatch(ExportedAllocationOwner sharedOwne
#endif
private unsafe static void ReleaseArray(CArrowArray* cArray)
{
- Dispose(&cArray->private_data);
+ for (long i = 0; i < cArray->n_children; i++)
+ {
+ CArrowArray.CallReleaseFunc(cArray->children[i]);
+ }
+ if (cArray->dictionary != null) {
Review Comment:
Ahah, sorry. Feel free to flag any other ones that I may have overlooked, as
it's a bit difficult to find them all by staring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
