bkietz commented on issue #37799: URL: https://github.com/apache/arrow/issues/37799#issuecomment-1737747352
I think in the presence of an origin schema, I think it's an error to prefer the inferred type. I'm a little surprised we don't already prefer the origin schema in all cases. Relatedly but as a separate issue, I think it's reasonable to support a common type between `time32[s]` and `time32[ms]`. That would be added to `CommonTemporal` in codegen_internal.cc https://github.com/bkietz/arrow/blob/ef1e1b84c32351729890eeb11c78b88fa852da94/cpp/src/arrow/compute/kernels/codegen_internal.cc#L248-L258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
