jorisvandenbossche commented on code in PR #34616: URL: https://github.com/apache/arrow/pull/34616#discussion_r1338910693
########## python/pyarrow/_dataset_parquet.pyx: ########## @@ -33,6 +33,12 @@ from pyarrow.includes.libarrow_dataset cimport * from pyarrow.includes.libarrow_dataset_parquet cimport * from pyarrow._fs cimport FileSystem +IF PARQUET_ENCRYPTION_ENABLED: Review Comment: > Oh, interesting. I didn't know that Cython allowed compile-time conditionals and that definitely makes things easier here :-) Well, they are planning to deprecate it .. (https://github.com/cython/cython/issues/4310). But as long as the discussion isn't yet clear, we can happily use this IMO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
