lriggs commented on code in PR #9060:
URL: https://github.com/apache/arrow/pull/9060#discussion_r1339392825


##########
cpp/src/gandiva/field_descriptor.h:
##########
@@ -58,12 +63,15 @@ class FieldDescriptor {
 
   bool HasDataBufferPtrIdx() const { return data_buffer_ptr_idx_ != 
kInvalidIdx; }
 
+  bool HasChildOffsetsIdx() const { return child_offsets_idx_ != kInvalidIdx; }
+
  private:
   FieldPtr field_;
   int data_idx_;
   int validity_idx_;
   int offsets_idx_;
   int data_buffer_ptr_idx_;
+  int child_offsets_idx_;

Review Comment:
   @NinaPeng I'm working on resurrecting this PR to add suport for lists in 
Gandiva. I got things working through java/jni but am now trying to add the 
validity vectors.  Do you have any more details on the approach mentioned 
above? Or maybe a PR I could look at? Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to