assignUser commented on code in PR #37684: URL: https://github.com/apache/arrow/pull/37684#discussion_r1340502532
########## r/tools/nixlibs-allowlist.txt: ########## @@ -2,3 +2,4 @@ ubuntu centos redhat rhel +darwin Review Comment: I understand the concerns and would agree with @nealrichardson that contacting CRAN and getting official approval is the best (if risky) way forward. With the bundled builds it should only be a matter of setting the feature flags to enable s3 and gcs for macos, everything else is covered by the default settings iirc. With regards to discussions with CRAN: another positive to this new system in addition to the f/reliability aspects is the improved archive-ability: currently without autobrew available the src package can not be build on mac as we do not ship the package with the local formulas we use in the nightly builds to build from apache/arrow@main. With these changes that will be possible. For linux an argument pro pre-compiled binary would be build/check times as arrow currently takes ~20x the checktime that dplyr takes and that is already on the longer side. So that would save cran a lot of resources and we could collaborate with them in someway to make sure one of the checks builds from source if they want that (that could just be setting `LIBARROW_BINARY=false`). For windows we are currently already hosting the binaries but are still using rwinlib primarily with our binaries as a fallback, we will need to switch that around for this release as well. I do want to extend the windows part of the build system to match linux and macos so that we can do source builds within the regular R package mechanisms but that won't be ready for the next release but could be mentioned if CRAN asks about windows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
