assignUser commented on code in PR #37684:
URL: https://github.com/apache/arrow/pull/37684#discussion_r1340511985
##########
r/tools/test-nixlibs.R:
##########
@@ -21,8 +21,8 @@
# Flag so that we just load the functions and don't evaluate them like we do
# when called from configure.R
TESTING <- TRUE
-
-source("nixlibs.R", local = TRUE)
+nixlibs_env <- environment()
Review Comment:
The tests are run in environments that don't have this env as a parent or
something so the `on_macos` var from the script is not modified if we just do
`on_macos <- TRUE` but the functions use the variable from the one they were
`source`ed in... maybe an argument to turn `on_macos` into a function or
something? Open to alternatives but wanted to get everything working first^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
