carols10cents opened a new pull request, #4876: URL: https://github.com/apache/arrow-rs/pull/4876
NOTE: This is currently a work in progress, and I'd love general feedback at this point to know that I'm going in the right direction! I think there's more refactoring I could do and tests I could add before this is ready for merging; and I'm not sure if this is the best public API or not. Also I haven't actually tested this against a live S3 bucket yet 😳 # Which issue does this PR close? Closes #4763. # Rationale for this change Enable reusing the authorization and signing code to generate signed URLs that can be used to give permission to upload or view particular objects. # What changes are included in this PR? A new public method on `AwsAuthorizer`, currently called `sign` (as opposed to the existing `authorize` method) that adds AWS signature query parameters to a specified `Url` so that it can be given to another user to authorize uploading or viewing a particular resource. This shares a lot of the signing code with the existing `authorize` method, so I've pulled out a few private methods, but I don't think the current structure is ideal yet. Thoughts on how far to take this are very welcome, such as if there's another struct or three starting to cry to be let out of `AwsAuthorizer`, if these should be free functions, etc. # Are there any user-facing changes? Yes, one new method, and I'd like to add an example of how to use this when you have an `AmazonS3` instance before merging this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
