CurtHagenlocher commented on code in PR #37885:
URL: https://github.com/apache/arrow/pull/37885#discussion_r1342707895
##########
csharp/test/Apache.Arrow.Tests/ArrowArrayConcatenatorTests.cs:
##########
@@ -495,6 +500,47 @@ public void Visit(UnionType type)
new[] { stringResultBuilder.Build().Data,
intResultBuilder.Build().Data }));
}
+ public void Visit(MapType type)
+ {
+ MapArray.Builder resultBuilder = new
MapArray.Builder(type).Reserve(_baseDataTotalElementCount);
+ //Todo : Support various types
Review Comment:
This comment was copied from some other implementation; there are now three
of these comments in this file. I don't think it's super important to test e.g.
Map<foo> vs Map<bar> so I've deleted all three copies of this comment from
ArrowArrayConcatenatorTests.cs and both copies from TestData.cs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
