CurtHagenlocher commented on code in PR #37885:
URL: https://github.com/apache/arrow/pull/37885#discussion_r1342720126
##########
csharp/src/Apache.Arrow/Arrays/ArrayDataConcatenator.cs:
##########
@@ -114,14 +107,15 @@ public void Visit(FixedSizeListType type)
public void Visit(StructType type)
{
CheckData(type, 1);
+ ArrowBuffer validityBuffer = ConcatenateValidityBuffer();
Review Comment:
The test I added for concatenating Map is what caught this. I then modified
the test for concatenating struct so that it was semantically correct and the
new version would have caught this too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
