zeroshade commented on code in PR #37785:
URL: https://github.com/apache/arrow/pull/37785#discussion_r1343241161


##########
go/parquet/internal/bmi/bmi_arm64.go:
##########
@@ -14,44 +14,51 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+//go:build !noasm
 // +build !noasm
 
 package bmi
 
 import (
+       "fmt"
        "os"
        "strings"
-)
-import (
-       "golang.org/x/sys/cpu"

Review Comment:
   @cyb70289 Here is the output of `lscpu` on the AWS EC2 instance that I've 
been using for testing:
   
   ```shell
   admin@ip-172-31-78-97:~/arrow/go/parquet/internal/utils$ lscpu
   Architecture:           aarch64
     CPU op-mode(s):       32-bit, 64-bit
     Byte Order:           Little Endian
   CPU(s):                 1
     On-line CPU(s) list:  0
   Vendor ID:              ARM
     Model name:           Neoverse-N1
       Model:              1
       Thread(s) per core: 1
       Core(s) per socket: 1
       Socket(s):          1
       Stepping:           r3p1
       BogoMIPS:           243.75
       Flags:              fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics 
fphp asimdhp cpuid asimdrdm lrcpc dcpop asimddp ssbs
   Caches (sum of all):
     L1d:                  64 KiB (1 instance)
     L1i:                  64 KiB (1 instance)
     L2:                   1 MiB (1 instance)
     L3:                   32 MiB (1 instance)
   NUMA:
     NUMA node(s):         1
     NUMA node0 CPU(s):    0
   Vulnerabilities:
     Gather data sampling: Not affected
     Itlb multihit:        Not affected
     L1tf:                 Not affected
     Mds:                  Not affected
     Meltdown:             Not affected
     Mmio stale data:      Not affected
     Retbleed:             Not affected
     Spec rstack overflow: Not affected
     Spec store bypass:    Mitigation; Speculative Store Bypass disabled via 
prctl
     Spectre v1:           Mitigation; __user pointer sanitization
     Spectre v2:           Mitigation; CSV2, BHB
     Srbds:                Not affected
     Tsx async abort:      Not affected
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to