zeroshade commented on code in PR #37785:
URL: https://github.com/apache/arrow/pull/37785#discussion_r1344292341
##########
go/parquet/internal/utils/clib_amd64.s:
##########
@@ -44,6 +44,15 @@ MEMCPY_BYTE_DONE:
POPQ R8
RET
+// func _ClibMemcpy(dst, src unsafe.Pointer, n uint) unsafe.Pointer
+TEXT ยท_ClibMemcpy(SB), NOSPLIT|NOFRAME, $16-24
Review Comment:
I didn't make any changes to the amd64 implementation which still uses
`memcpy`. Since there's no issues or problems with the amd64 implementation, I
didn't want to change or remove anything with it. I just left the addition the
Go function definition there for easier testing in the future if we need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
