viirya commented on code in PR #7631:
URL: https://github.com/apache/arrow-datafusion/pull/7631#discussion_r1344427424


##########
datafusion/core/src/execution/context.rs:
##########
@@ -286,9 +286,16 @@ impl SessionContext {
     ///
     /// See [`Self::with_config_rt`] for more details on resource
     /// limits.
-    pub fn with_config(config: SessionConfig) -> Self {
+    pub fn new_with_config(config: SessionConfig) -> Self {
         let runtime = Arc::new(RuntimeEnv::default());
-        Self::with_config_rt(config, runtime)
+        Self::new_with_config_rt(config, runtime)
+    }
+
+    /// Creates a new `SessionContext` using the provided
+    /// [`SessionConfig`] and a new [`RuntimeEnv`].
+    #[deprecated(since = "23.0.0", note = "Use 
SessionContext::new_with_config")]

Review Comment:
   ```suggestion
       #[deprecated(since = "32.0.0", note = "Use 
SessionContext::new_with_config")]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to