viirya commented on code in PR #7631:
URL: https://github.com/apache/arrow-datafusion/pull/7631#discussion_r1344429332
##########
datafusion/core/src/execution/context.rs:
##########
@@ -1396,25 +1419,23 @@ impl Debug for SessionState {
}
}
-/// Default session builder using the provided configuration
-#[deprecated(
- since = "23.0.0",
- note = "See SessionContext::with_config() or SessionState::with_config_rt"
-)]
-pub fn default_session_builder(config: SessionConfig) -> SessionState {
- SessionState::with_config_rt(config, Arc::new(RuntimeEnv::default()))
-}
-
impl SessionState {
/// Returns new [`SessionState`] using the provided
/// [`SessionConfig`] and [`RuntimeEnv`].
- pub fn with_config_rt(config: SessionConfig, runtime: Arc<RuntimeEnv>) ->
Self {
+ pub fn new_with_config_rt(config: SessionConfig, runtime: Arc<RuntimeEnv>)
-> Self {
let catalog_list = Arc::new(MemoryCatalogList::new()) as Arc<dyn
CatalogList>;
- Self::with_config_rt_and_catalog_list(config, runtime, catalog_list)
+ Self::new_with_config_rt_and_catalog_list(config, runtime,
catalog_list)
}
- /// Returns new SessionState using the provided configuration, runtime and
catalog list.
- pub fn with_config_rt_and_catalog_list(
+ /// Returns new [`SessionState`] using the provided
+ /// [`SessionConfig`] and [`RuntimeEnv`]. #[deprecated(since =
"32.0.0", note = "Use SessionState::new_with_config_rt")]
Review Comment:
```suggestion
/// [`SessionConfig`] and [`RuntimeEnv`].
#[deprecated(since = "32.0.0", note = "Use
SessionState::new_with_config_rt")]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
