fatemehp commented on code in PR #37003:
URL: https://github.com/apache/arrow/pull/37003#discussion_r1344786897


##########
cpp/src/parquet/file_reader.h:
##########
@@ -24,6 +24,7 @@
 
 #include "arrow/io/caching.h"
 #include "arrow/util/type_fwd.h"
+#include "parquet/column_reader.h"

Review Comment:
   I couldn't get the forward declaration work with the internal namespace. I 
get this error:
   `error: declaration ‘class parquet::internal::RecordReader’ does not declare 
anything [-Werror]
      38 | class internal::RecordReader;
   `



##########
cpp/src/parquet/file_reader.h:
##########
@@ -24,6 +24,7 @@
 
 #include "arrow/io/caching.h"
 #include "arrow/util/type_fwd.h"
+#include "parquet/column_reader.h"

Review Comment:
   I couldn't get the forward declaration work with the internal namespace. I 
get this error:
   `error: declaration ‘class parquet::internal::RecordReader’ does not declare 
anything [-Werror]
      38 | class internal::RecordReader;
   `



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to