fatemehp commented on code in PR #37003:
URL: https://github.com/apache/arrow/pull/37003#discussion_r1346401165
##########
cpp/src/parquet/reader_test.cc:
##########
@@ -502,6 +502,25 @@ TEST_F(TestAllTypesPlain, ColumnSelectionOutOfRange) {
ASSERT_THROW(printer2.DebugPrint(ss, columns), ParquetException);
}
+// Tests getting a record reader from a row group reader.
+TEST(TestFileReader, GetRecordReader) {
+ ReaderProperties reader_props;
+ reader_props.enable_read_dense_for_nullable();
+ std::unique_ptr<ParquetFileReader> file_reader = ParquetFileReader::OpenFile(
+ alltypes_plain(), /* memory_map = */ false, reader_props);
+ std::shared_ptr<RowGroupReader> group = file_reader->RowGroup(0);
+
+ std::shared_ptr<internal::RecordReader> col_record_reader_ =
group->RecordReader(0);
+
+ ASSERT_TRUE(col_record_reader_->read_dense_for_nullable());
Review Comment:
The goal here is to test if the option is passed down to the underlying
record reader. I added a separate more comprehensive test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
