joemarshall commented on code in PR #37821:
URL: https://github.com/apache/arrow/pull/37821#discussion_r1345493363
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1614,6 +1619,9 @@ macro(build_thrift)
if(DEFINED BOOST_ROOT)
list(APPEND THRIFT_CMAKE_ARGS "-DBOOST_ROOT=${BOOST_ROOT}")
endif()
+ if(DEFINED Boost_INCLUDE_DIR)
+ list(APPEND THRIFT_CMAKE_ARGS "-DBoost_INCLUDE_DIR=${Boost_INCLUDE_DIR}")
Review Comment:
I passed the result var as it short circuits a load of logic in findboost
which was breaking. I suspect that's why the namespace is passed similarly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
