joemarshall commented on code in PR #37821:
URL: https://github.com/apache/arrow/pull/37821#discussion_r1345514812
##########
cpp/CMakePresets.json:
##########
@@ -368,6 +421,16 @@
"displayName": "Release build with Gandiva",
"cacheVariables": {}
},
+ {
+ "name": "ninja-release-python-emscripten",
+ "inherits": [
+ "features-emscripten",
+ "base-release",
+ "features-python"
Review Comment:
it is in as
```
"features-emscripten",
"base-release"
```
and
```
"features-emscripten",
"base-debug"
```
It needs to be in that order because things from base need overriding (base
sets 'ARROW_BUILD_STATIC' off.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
