alamb commented on code in PR #7735: URL: https://github.com/apache/arrow-datafusion/pull/7735#discussion_r1345874080
########## datafusion/sqllogictest/test_files/information_schema.slt: ########## @@ -136,91 +136,91 @@ statement ok SET datafusion.execution.parquet.created_by=datafusion # show all variables -query TT rowsort +query TTT rowsort SHOW ALL ---- -datafusion.catalog.create_default_catalog_and_schema true -datafusion.catalog.default_catalog datafusion -datafusion.catalog.default_schema public -datafusion.catalog.format NULL -datafusion.catalog.has_header false -datafusion.catalog.information_schema true -datafusion.catalog.location NULL -datafusion.execution.aggregate.scalar_update_factor 10 -datafusion.execution.batch_size 8192 -datafusion.execution.coalesce_batches true -datafusion.execution.collect_statistics false -datafusion.execution.meta_fetch_concurrency 32 -datafusion.execution.parquet.allow_single_file_parallelism false -datafusion.execution.parquet.bloom_filter_enabled false -datafusion.execution.parquet.bloom_filter_fpp NULL -datafusion.execution.parquet.bloom_filter_ndv NULL -datafusion.execution.parquet.column_index_truncate_length NULL -datafusion.execution.parquet.compression zstd(3) -datafusion.execution.parquet.created_by datafusion -datafusion.execution.parquet.data_page_row_count_limit 18446744073709551615 -datafusion.execution.parquet.data_pagesize_limit 1048576 -datafusion.execution.parquet.dictionary_enabled NULL -datafusion.execution.parquet.dictionary_page_size_limit 1048576 -datafusion.execution.parquet.enable_page_index true -datafusion.execution.parquet.encoding NULL -datafusion.execution.parquet.max_row_group_size 1048576 -datafusion.execution.parquet.max_statistics_size NULL -datafusion.execution.parquet.metadata_size_hint NULL -datafusion.execution.parquet.pruning true -datafusion.execution.parquet.pushdown_filters false -datafusion.execution.parquet.reorder_filters false -datafusion.execution.parquet.skip_metadata true -datafusion.execution.parquet.statistics_enabled NULL -datafusion.execution.parquet.write_batch_size 1024 -datafusion.execution.parquet.writer_version 1.0 -datafusion.execution.planning_concurrency 13 -datafusion.execution.sort_in_place_threshold_bytes 1048576 -datafusion.execution.sort_spill_reservation_bytes 10485760 -datafusion.execution.target_partitions 7 -datafusion.execution.time_zone +00:00 -datafusion.explain.logical_plan_only false -datafusion.explain.physical_plan_only false -datafusion.explain.show_statistics false -datafusion.optimizer.allow_symmetric_joins_without_pruning true -datafusion.optimizer.bounded_order_preserving_variants false -datafusion.optimizer.enable_round_robin_repartition true -datafusion.optimizer.enable_topk_aggregation true -datafusion.optimizer.filter_null_join_keys false -datafusion.optimizer.hash_join_single_partition_threshold 1048576 -datafusion.optimizer.max_passes 3 -datafusion.optimizer.prefer_hash_join true -datafusion.optimizer.repartition_aggregations true -datafusion.optimizer.repartition_file_min_size 10485760 -datafusion.optimizer.repartition_file_scans true -datafusion.optimizer.repartition_joins true -datafusion.optimizer.repartition_sorts true -datafusion.optimizer.repartition_windows true -datafusion.optimizer.skip_failed_rules false -datafusion.optimizer.top_down_join_key_reordering true -datafusion.sql_parser.dialect generic -datafusion.sql_parser.enable_ident_normalization true -datafusion.sql_parser.parse_float_as_decimal false +datafusion.catalog.create_default_catalog_and_schema true Whether the default catalog and schema should be created automatically. Review Comment: Maybe we could follow the Rustdoc convention and only show the first sentence of the description as part of `SHOW ALL`, and then the full docs via `SHOW ALL VERBOSE/EXTENDED` 🤔 Doing this would likely require rewording some of the descriptions so the first sentence contained the right summary. ########## datafusion/sqllogictest/test_files/information_schema.slt: ########## @@ -136,91 +136,91 @@ statement ok SET datafusion.execution.parquet.created_by=datafusion # show all variables -query TT rowsort +query TTT rowsort SHOW ALL ---- -datafusion.catalog.create_default_catalog_and_schema true -datafusion.catalog.default_catalog datafusion -datafusion.catalog.default_schema public -datafusion.catalog.format NULL -datafusion.catalog.has_header false -datafusion.catalog.information_schema true -datafusion.catalog.location NULL -datafusion.execution.aggregate.scalar_update_factor 10 -datafusion.execution.batch_size 8192 -datafusion.execution.coalesce_batches true -datafusion.execution.collect_statistics false -datafusion.execution.meta_fetch_concurrency 32 -datafusion.execution.parquet.allow_single_file_parallelism false -datafusion.execution.parquet.bloom_filter_enabled false -datafusion.execution.parquet.bloom_filter_fpp NULL -datafusion.execution.parquet.bloom_filter_ndv NULL -datafusion.execution.parquet.column_index_truncate_length NULL -datafusion.execution.parquet.compression zstd(3) -datafusion.execution.parquet.created_by datafusion -datafusion.execution.parquet.data_page_row_count_limit 18446744073709551615 -datafusion.execution.parquet.data_pagesize_limit 1048576 -datafusion.execution.parquet.dictionary_enabled NULL -datafusion.execution.parquet.dictionary_page_size_limit 1048576 -datafusion.execution.parquet.enable_page_index true -datafusion.execution.parquet.encoding NULL -datafusion.execution.parquet.max_row_group_size 1048576 -datafusion.execution.parquet.max_statistics_size NULL -datafusion.execution.parquet.metadata_size_hint NULL -datafusion.execution.parquet.pruning true -datafusion.execution.parquet.pushdown_filters false -datafusion.execution.parquet.reorder_filters false -datafusion.execution.parquet.skip_metadata true -datafusion.execution.parquet.statistics_enabled NULL -datafusion.execution.parquet.write_batch_size 1024 -datafusion.execution.parquet.writer_version 1.0 -datafusion.execution.planning_concurrency 13 -datafusion.execution.sort_in_place_threshold_bytes 1048576 -datafusion.execution.sort_spill_reservation_bytes 10485760 -datafusion.execution.target_partitions 7 -datafusion.execution.time_zone +00:00 -datafusion.explain.logical_plan_only false -datafusion.explain.physical_plan_only false -datafusion.explain.show_statistics false -datafusion.optimizer.allow_symmetric_joins_without_pruning true -datafusion.optimizer.bounded_order_preserving_variants false -datafusion.optimizer.enable_round_robin_repartition true -datafusion.optimizer.enable_topk_aggregation true -datafusion.optimizer.filter_null_join_keys false -datafusion.optimizer.hash_join_single_partition_threshold 1048576 -datafusion.optimizer.max_passes 3 -datafusion.optimizer.prefer_hash_join true -datafusion.optimizer.repartition_aggregations true -datafusion.optimizer.repartition_file_min_size 10485760 -datafusion.optimizer.repartition_file_scans true -datafusion.optimizer.repartition_joins true -datafusion.optimizer.repartition_sorts true -datafusion.optimizer.repartition_windows true -datafusion.optimizer.skip_failed_rules false -datafusion.optimizer.top_down_join_key_reordering true -datafusion.sql_parser.dialect generic -datafusion.sql_parser.enable_ident_normalization true -datafusion.sql_parser.parse_float_as_decimal false +datafusion.catalog.create_default_catalog_and_schema true Whether the default catalog and schema should be created automatically. Review Comment: Maybe we could follow the Rustdoc convention and only show the first sentence of the description as part of `SHOW ALL`, and then the full docs via `SHOW ALL VERBOSE/EXTENDED` 🤔 Doing this would likely require rewording some of the descriptions so the first sentence contained the right summary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
