alamb commented on code in PR #7735:
URL: https://github.com/apache/arrow-datafusion/pull/7735#discussion_r1347825540


##########
datafusion/sqllogictest/test_files/information_schema.slt:
##########
@@ -202,12 +202,85 @@ datafusion.sql_parser.dialect generic
 datafusion.sql_parser.enable_ident_normalization true
 datafusion.sql_parser.parse_float_as_decimal false
 
+# show all variables with verbose
+query TTT rowsort

Review Comment:
   🥇 



##########
docs/source/user-guide/cli.md:
##########
@@ -397,11 +397,13 @@ Available commands inside DataFusion CLI are:
 
 - Show configuration options
 
+`SHOW ALL [VERBOSE]`
+
 ```SQL
 > show all;
 
 +-------------------------------------------------+---------+
-| name                                            | setting |
+| name                                            | value   |

Review Comment:
   I like this change in column name 👍 



##########
datafusion/sqllogictest/test_files/information_schema.slt:
##########
@@ -202,12 +202,85 @@ datafusion.sql_parser.dialect generic
 datafusion.sql_parser.enable_ident_normalization true
 datafusion.sql_parser.parse_float_as_decimal false
 
+# show all variables with verbose
+query TTT rowsort

Review Comment:
   🥇 



##########
docs/source/user-guide/cli.md:
##########
@@ -397,11 +397,13 @@ Available commands inside DataFusion CLI are:
 
 - Show configuration options
 
+`SHOW ALL [VERBOSE]`
+
 ```SQL
 > show all;
 
 +-------------------------------------------------+---------+
-| name                                            | setting |
+| name                                            | value   |

Review Comment:
   I like this change in column name 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to