jonkeane commented on code in PR #37684:
URL: https://github.com/apache/arrow/pull/37684#discussion_r1346273923
##########
r/configure:
##########
@@ -175,12 +165,6 @@ find_arrow () {
# 2. Use pkg-config to find arrow on the system
_LIBARROW_FOUND="`${PKG_CONFIG} --variable=prefix --silence-errors
${PKG_CONFIG_NAME}`"
echo "*** Trying Arrow C++ found by pkg-config: $_LIBARROW_FOUND"
- elif brew --prefix ${PKG_BREW_NAME} > /dev/null 2>&1; then
- # 3. On macOS, look for Homebrew apache-arrow
- # (note that if you have pkg-config, homebrew arrow may have already
been found)
- _LIBARROW_FOUND=`brew --prefix ${PKG_BREW_NAME}`
- echo "*** Trying Arrow C++ found by Homebrew: ${_LIBARROW_FOUND}"
- export
PKG_CONFIG_PATH="${_LIBARROW_FOUND}/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"
Review Comment:
I'm not sure I agree that this is a pattern we want to get rid of so quickly
(I've onboarded a number of new contributors, and if they've got a purely R
fix,`brew install apache-arrow --HEAD` was the quickest way forward.
But if this is removed, we should also update the docs at
https://arrow.apache.org/docs/r/articles/developers/setup.html (and anywhere
else we've listed that)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
