assignUser commented on code in PR #37684:
URL: https://github.com/apache/arrow/pull/37684#discussion_r1346438542
##########
r/configure:
##########
@@ -175,12 +165,6 @@ find_arrow () {
# 2. Use pkg-config to find arrow on the system
_LIBARROW_FOUND="`${PKG_CONFIG} --variable=prefix --silence-errors
${PKG_CONFIG_NAME}`"
echo "*** Trying Arrow C++ found by pkg-config: $_LIBARROW_FOUND"
- elif brew --prefix ${PKG_BREW_NAME} > /dev/null 2>&1; then
- # 3. On macOS, look for Homebrew apache-arrow
- # (note that if you have pkg-config, homebrew arrow may have already
been found)
- _LIBARROW_FOUND=`brew --prefix ${PKG_BREW_NAME}`
- echo "*** Trying Arrow C++ found by Homebrew: ${_LIBARROW_FOUND}"
- export
PKG_CONFIG_PATH="${_LIBARROW_FOUND}/lib/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}"
Review Comment:
I think we should add a mechanism to get the latest nightly binary when the
dev version is .9000 and handle that os agnostic (iirc there is a issues open
for that already). If that doesn't work due to incompatibility we/user can just
build from source (e.g. via `LIBARROW_BINARY=FALSE`). On a git checkout this
would need `make sync-cpp` but I want to integrate that into normal {pkgbuild}
path via bootstrap.R soon.
But I can also add this back for now :shrug:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
