kou commented on code in PR #37684:
URL: https://github.com/apache/arrow/pull/37684#discussion_r1346680441
##########
dev/tasks/r/github.packages.yml:
##########
@@ -56,6 +56,56 @@ jobs:
name: r-pkg__src__contrib
path: arrow/r/arrow_*.tar.gz
+ macos-cpp:
+ name: C++ Binary macOS OpenSSL {{ '${{ matrix.openssl }}' }} {{ '${{
matrix.platform.arch }}'}}
+ runs-on: {{ '${{ matrix.platform.runs_on }}'}}
Review Comment:
```suggestion
runs-on: {{ '${{ matrix.platform.runs_on }}' }}
```
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -456,11 +456,18 @@ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" OR
CMAKE_CXX_COMPILER_ID STRE
# Don't complain about optimization passes that were not possible
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wno-pass-failed")
- # Avoid clang / libc++ error about C++17 aligned allocation on macOS.
- # See
https://chromium.googlesource.com/chromium/src/+/eee44569858fc650b635779c4e34be5cb0c73186%5E%21/#F0
- # for details.
if(APPLE)
+ # Avoid clang / libc++ error about C++17 aligned allocation on macOS.
+ # See
https://chromium.googlesource.com/chromium/src/+/eee44569858fc650b635779c4e34be5cb0c73186%5E%21/#F0
+ # for details.
set(CXX_ONLY_FLAGS "${CXX_ONLY_FLAGS} -fno-aligned-new")
Review Comment:
```suggestion
string(APPEND CXX_ONLY_FLAGS " -fno-aligned-new")
```
##########
dev/tasks/r/github.packages.yml:
##########
@@ -56,6 +56,56 @@ jobs:
name: r-pkg__src__contrib
path: arrow/r/arrow_*.tar.gz
+ macos-cpp:
+ name: C++ Binary macOS OpenSSL {{ '${{ matrix.openssl }}' }} {{ '${{
matrix.platform.arch }}'}}
+ runs-on: {{ '${{ matrix.platform.runs_on }}'}}
+ needs: source
+ strategy:
+ fail-fast: false
+ matrix:
+ platform:
+ - { runs_on: ["self-hosted", "macos-10.13"], arch: "x86_64" }
Review Comment:
```suggestion
- { runs_on: ["self-hosted", "macos-10.13"], arch: "x86_64" }
```
##########
dev/tasks/r/github.packages.yml:
##########
@@ -56,6 +56,56 @@ jobs:
name: r-pkg__src__contrib
path: arrow/r/arrow_*.tar.gz
+ macos-cpp:
+ name: C++ Binary macOS OpenSSL {{ '${{ matrix.openssl }}' }} {{ '${{
matrix.platform.arch }}'}}
Review Comment:
```suggestion
name: C++ Binary macOS OpenSSL {{ '${{ matrix.openssl }}' }} {{ '${{
matrix.platform.arch }}' }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
