AlenkaF commented on code in PR #37768:
URL: https://github.com/apache/arrow/pull/37768#discussion_r1347259958
##########
python/pyarrow/tests/test_fs.py:
##########
@@ -699,12 +699,12 @@ def test_get_file_info_with_selector(fs, pathfn):
infos = fs.get_file_info(selector)
if fs.type_name == "py::fsspec+s3":
- # s3fs only lists directories if they are not empty, but depending
- # on the s3fs/fsspec version combo, it includes the base_dir
+ # s3fs only lists directories if they are not empty
# (https://github.com/dask/s3fs/issues/393)
- assert (len(infos) == 4) or (len(infos) == 5)
+ len(infos) == 4
else:
assert len(infos) == 5
+ assert base_dir not in infos
Review Comment:
You are correct. Will remove this lines.
(I am having trouble testing it locally as the test is failing on current
master for me. Can't figure out why)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
