jorisvandenbossche commented on code in PR #37768:
URL: https://github.com/apache/arrow/pull/37768#discussion_r1352275415
##########
python/pyarrow/tests/test_fs.py:
##########
@@ -699,10 +699,7 @@ def test_get_file_info_with_selector(fs, pathfn):
infos = fs.get_file_info(selector)
if fs.type_name == "py::fsspec+s3":
- # s3fs only lists directories if they are not empty, but depending
- # on the s3fs/fsspec version combo, it includes the base_dir
- # (https://github.com/dask/s3fs/issues/393)
- assert (len(infos) == 4) or (len(infos) == 5)
+ len(infos) == 4
Review Comment:
```suggestion
# s3fs only lists directories if they are not empty
len(infos) == 4
```
(that first part is still valid)
##########
python/pyarrow/tests/test_fs.py:
##########
@@ -726,11 +719,7 @@ def test_get_file_info_with_selector(fs, pathfn):
infos = fs.get_file_info(selector)
if fs.type_name == "py::fsspec+s3":
- # s3fs only lists directories if they are not empty
- # + for s3fs 0.5.2 all directories are dropped because of buggy
- # side-effect of previous find() call
- # (https://github.com/dask/s3fs/issues/410)
- assert (len(infos) == 3) or (len(infos) == 2)
+ assert len(infos) == 3
Review Comment:
```suggestion
# s3fs only lists directories if they are not empty
assert len(infos) == 3
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
