pitrou commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1347376880
##########
python/pyarrow/_dataset_parquet.pyx:
##########
@@ -711,6 +889,20 @@ cdef class ParquetFragmentScanOptions(FragmentScanOptions):
cdef ArrowReaderProperties* arrow_reader_properties(self):
return self.parquet_options.arrow_reader_properties.get()
+ IF PARQUET_ENCRYPTION_ENABLED:
+ @property
+ def parquet_decryption_config(self):
Review Comment:
> Do we want to define these functions with an ELSE statement and then throw
an exception if they are called?
Yes, because right now the user would probably get a generic error such as
`AttributeError("ParquetFragmentScanOptions has no attribute
'parquet_decryption_config'")`, which may also occur because of a typo in the
attribute name, while it might be more informative to have something like
`NotImplementedError("Trying access the 'parquet_decryption_config' attribute
but encryption is not enabled in this build")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
