danepitkin commented on code in PR #37723:
URL: https://github.com/apache/arrow/pull/37723#discussion_r1347824287
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/Accountant.java:
##########
@@ -286,7 +288,7 @@ public void setLimit(long newLimit) {
*
* @return Currently allocate memory in bytes.
*/
- public long getAllocatedMemory() {
+ public long getAllocatedMemory(Accountant this) {
Review Comment:
Hmm, is this needed? It's not used.
##########
java/pom.xml:
##########
@@ -46,6 +46,7 @@
<errorprone.javac.version>9+181-r4173-1</errorprone.javac.version>
<error_prone_core.version>2.16</error_prone_core.version>
<maven-compiler-plugin.version>3.10.1</maven-compiler-plugin.version>
+ <checker.framework.version>3.38.0</checker.framework.version>
Review Comment:
v3.39.0 just released a few days ago, which adds additional support for Java
21 compilation
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/StackTrace.java:
##########
@@ -29,6 +29,7 @@ public class StackTrace {
/**
* Constructor. Captures the current stack trace.
*/
+ @SuppressWarnings("nullness:assignment") //incompatible types in assignment
Review Comment:
Can you expand on why this is suppressed? `nullness:assignment` warning
makes me think we can just check the length of the stack trace to make sure we
are copying valid entries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
