jorisvandenbossche commented on code in PR #38070:
URL: https://github.com/apache/arrow/pull/38070#discussion_r1348626768
##########
python/pyarrow/parquet/core.py:
##########
@@ -821,7 +823,10 @@ def _sanitize_table(table, new_schema, flavor):
and should be combined with a compression codec.
column_encoding : string or dict, default None
Specify the encoding scheme on a per column basis.
- Currently supported values: {'PLAIN', 'BYTE_STREAM_SPLIT'}.
+ Only if "use_dictionary" and "use_byte_stream_split" is False,
+ the following encodings are supported.
+ Currently supported values: {'PLAIN', 'BYTE_STREAM_SPLIT',
+ 'DELTA_BINARY_PACKED', 'DELTA_LENGTH_BYTE_ARRAY', 'DELTA_BYTE_ARRAY'}.
Review Comment:
Strictly speaking, "RLE" is also allowed, but since that is now the default
and only valid for booleans, there is probably no use in actually specifying it.
##########
python/pyarrow/parquet/core.py:
##########
@@ -770,6 +770,8 @@ def _sanitize_table(table, new_schema, flavor):
use_dictionary : bool or list
Review Comment:
```suggestion
use_dictionary : bool or list, default True
```
##########
python/pyarrow/parquet/core.py:
##########
@@ -821,7 +823,10 @@ def _sanitize_table(table, new_schema, flavor):
and should be combined with a compression codec.
column_encoding : string or dict, default None
Specify the encoding scheme on a per column basis.
- Currently supported values: {'PLAIN', 'BYTE_STREAM_SPLIT'}.
+ Only if "use_dictionary" and "use_byte_stream_split" is False,
+ the following encodings are supported.
Review Comment:
```suggestion
Can only be used when when "use_dictionary" is set to False, and cannot
be
used in combination with "use_byte_stream_split".
```
(`use_byte_stream_split` is already False by default, in contrast to
dictionary encoding)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
