mapleFU commented on code in PR #38070:
URL: https://github.com/apache/arrow/pull/38070#discussion_r1350376650


##########
python/pyarrow/parquet/core.py:
##########
@@ -821,7 +823,10 @@ def _sanitize_table(table, new_schema, flavor):
     and should be combined with a compression codec.
 column_encoding : string or dict, default None
     Specify the encoding scheme on a per column basis.
-    Currently supported values: {'PLAIN', 'BYTE_STREAM_SPLIT'}.
+    Only if "use_dictionary" and "use_byte_stream_split" is False, 
+    the following encodings are supported.
+    Currently supported values: {'PLAIN', 'BYTE_STREAM_SPLIT', 
+    'DELTA_BINARY_PACKED', 'DELTA_LENGTH_BYTE_ARRAY', 'DELTA_BYTE_ARRAY'}.

Review Comment:
   Rle is default enabled on Page V2, however, write page v2 is not recommended.
   
   Page V2 format is great, however, most parquet implementions didn't get 
agreement on it. As a result, page v2 is unstable now.
   
   RLE Boolean is default enabled on page v2, I think it's ok there, but I 
don't think is a good idea to default enable it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to