mapleFU commented on code in PR #38073:
URL: https://github.com/apache/arrow/pull/38073#discussion_r1348655100
##########
cpp/src/parquet/file_reader.cc:
##########
@@ -365,6 +367,20 @@ class SerializedFile : public ParquetFileReader::Contents {
ComputeColumnChunkRange(file_metadata_.get(), source_size_, row,
col));
}
}
+#ifndef NDEBUG
+ if (!ranges.empty()) {
Review Comment:
Maybe it's a better place to put this check in, which is more proper and
might avoid some performance loss. I'm on the high railway home, so I don't
have enough time to check this carefully. Any idea is welcome
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
