lidavidm commented on code in PR #38073: URL: https://github.com/apache/arrow/pull/38073#discussion_r1348858926
########## cpp/src/arrow/io/util_internal.h: ########## @@ -45,9 +45,9 @@ ARROW_EXPORT Status ValidateWriteRange(int64_t offset, int64_t size, int64_t fil ARROW_EXPORT Status ValidateRange(int64_t offset, int64_t size); ARROW_EXPORT -std::vector<ReadRange> CoalesceReadRanges(std::vector<ReadRange> ranges, - int64_t hole_size_limit, - int64_t range_size_limit); +Result<std::vector<ReadRange>> CoalesceReadRanges(std::vector<ReadRange> ranges, Review Comment: It's in an `internal` header so no expectation that it remains stable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
