BryanCutler commented on PR #38110: URL: https://github.com/apache/arrow/pull/38110#issuecomment-1751445924
@lidavidm I was playing around with the DoExchange call and noticed a couple of issues. At first I was a little confused as to why `getWriter().getResult()` wasn't being called until I realized that errors were coming through the reader. If `getWriter().getResult()` is called before `getReader().next()` is called a final time, then it seems to hang. So I noticed that you really need to call `getReader().next()` a final time, so it will return false or raise any errors that happened after exchanging all the batches. To hopefully make this more clear to the user I added `ExchangeReaderWriter.getResult()` so it will be obvious to call this instead. I'm not 100% sure that it's a good idea, so let me know what you think. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
