BryanCutler commented on code in PR #38110:
URL: https://github.com/apache/arrow/pull/38110#discussion_r1355775352
##########
java/flight/flight-core/src/main/java/org/apache/arrow/flight/FlightStream.java:
##########
@@ -207,6 +207,8 @@ public void close() throws Exception {
} else {
AutoCloseables.close(closeables);
}
+ // Remove any metadata after closing to prevent negative refcnt
+ applicationMetadata = null;
Review Comment:
I put it here because if something throws and error before this, it's likely
the buffer was not closed then. So at least this way, the buffer could be
examined, but either way there is probably some resources leaked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
