alamb opened a new pull request, #7785: URL: https://github.com/apache/arrow-datafusion/pull/7785
## Which issue does this PR close? related to https://github.com/apache/arrow-datafusion/issues/7776 ## Rationale for this change While reviewing https://github.com/apache/arrow-datafusion/issues/7776, I noticed that the parameter values were not well documented. So I started trying to write documentation examples and in so doing found several usability papercuts that I I also fixed. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? 1. Doc comments for `LogicalPlan::with_param_values` and YYY with examples 2. Add `placeholder` to `expr_fn function to more easily construct placeholders 3. Move `infer_placeholder_values` to Expr, and make it public (so it can be used outside of the context of a SQL statement) 4. Change `LogicalPlan::with_param_values` to also substitute parameter values for non `PREPARE` statements as well <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? Yes, new tests / doc comments ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
