jayzhan211 commented on code in PR #7629:
URL: https://github.com/apache/arrow-datafusion/pull/7629#discussion_r1353775489
##########
datafusion/common/src/scalar.rs:
##########
@@ -1653,42 +1619,66 @@ impl ScalarValue {
Ok(array)
}
- fn iter_to_array_list(
- scalars: impl IntoIterator<Item = ScalarValue>,
+ // This function does not contains nulls but empty array instead.
Review Comment:
NullBuffer for ListArray is `None` in this function, you can't get `NULL` in
the array from this function, only an empty array is possible.
I tried to have one function for `iter_to_array_list_without_nulls` and
`iter_to_array_list` but failed since one needs nulls, and another needs an
empty array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
