jayzhan211 commented on code in PR #7629:
URL: https://github.com/apache/arrow-datafusion/pull/7629#discussion_r1355080025
##########
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -602,32 +551,6 @@ fn round_trip_scalar_values() {
i64::MAX,
))),
ScalarValue::IntervalMonthDayNano(None),
- ScalarValue::new_list(
Review Comment:
> It seems like it would be easier to understand the ListArray coverage if
we kept the test structure as is 🤔
Nice suggestion, it looks really nice now
##########
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -602,32 +551,6 @@ fn round_trip_scalar_values() {
i64::MAX,
))),
ScalarValue::IntervalMonthDayNano(None),
- ScalarValue::new_list(
Review Comment:
> It seems like it would be easier to understand the ListArray coverage if
we kept the test structure as is 🤔
Nice suggestion, it looks really nice now
##########
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -602,32 +551,6 @@ fn round_trip_scalar_values() {
i64::MAX,
))),
ScalarValue::IntervalMonthDayNano(None),
- ScalarValue::new_list(
Review Comment:
> It seems like it would be easier to understand the ListArray coverage if
we kept the test structure as is 🤔
Nice suggestion, it looks really nice now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
