jonkeane commented on code in PR #38236:
URL: https://github.com/apache/arrow/pull/38236#discussion_r1357046190
##########
r/tools/nixlibs.R:
##########
@@ -133,16 +125,16 @@ identify_binary <- function(lib =
Sys.getenv("LIBARROW_BINARY"), info = distro()
if (identical(lib, "false")) {
# Do not download a binary
- NULL
+ lib <- NULL
} else if (!identical(lib, "true")) {
# Env var provided an os-version to use, to override our logic.
# We don't validate that this exists. If it doesn't, the download will fail
# and the build will fall back to building from source
- lib
Review Comment:
There are other ways to avoid this: You could also not have that branch (and
possibly edit the conditions branch below), no? Or keep the
return-the-last-value logic that was there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
